davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-302760914 Aha! Good catch. On Fri, May 19, 2017 at 11:06 AM, Eric Avdey <[email protected]> wrote: > *@eiri* commented on this pull request. > ------------------------------ > > In src/couch/src/couch_server.erl > <https://github.com/apache/couchdb/pull/496#discussion_r117517242>: > > > + case couch_db_engine:exists(Engine, Path) of > + true -> > + [{Engine, Path} | Acc]; > + false -> > + Acc > + end > + end, [], Engines). > + > + > +get_default_engine(Server, DbName) -> > + #server{ > + root_dir = RootDir, > + engines = Engines > + } = Server, > + Default = {couch_bt_engine, make_filepath(RootDir, DbName, "couch")}, > + case config:get("couchdb", "default_engine") of > > @davisp <https://github.com/davisp> Tony right about "default_engine" > been ignored, but the problem not here, but in chttpd_db.erl > <https://github.com/apache/couchdb/blob/7162a24ba6b6341a9c015a5fc6b6f4d4306ba432/src/chttpd/src/chttpd_db.erl#L287l> > - if query "engine" is missing it defaults to "couch", so "default_engine" > is essentially always ignored. > > ? > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/couchdb/pull/496#discussion_r117517242>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AABN2WfWGOc_nMwGy2uc9i-AAh4DaAuzks5r7b4RgaJpZM4NKWJX> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
