davisp commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-311163050 Looks like not because it doesn't appear to exist in 17.x On Mon, Jun 26, 2017 at 8:11 AM, garren smith <[email protected]> wrote: > *@garrensmith* commented on this pull request. > ------------------------------ > > In src/couch/src/test_engine_fold_changes.erl > <https://github.com/apache/couchdb/pull/496#discussion_r124004438>: > > > + {ok, RevOrder} = Engine:fold_changes(St, 0, fun fold_fun/2, [], []), > + ?assertEqual(FinalDocSeqs, lists:reverse(RevOrder)), > + ok; > + > +do_mutation_ordering(Engine, St, Seq, [{DocId, _OldSeq} | Rest], DocSeqAcc) -> > + Actions = [{update, {DocId, []}}], > + {ok, NewSt} = test_engine_util:apply_actions(Engine, St, Actions), > + NewAcc = DocSeqAcc ++ [{DocId, Seq}], > + Expected = Rest ++ NewAcc, > + {ok, RevOrder} = Engine:fold_changes(NewSt, 0, fun fold_fun/2, [], []), > + ?assertEqual(Expected, lists:reverse(RevOrder)), > + do_mutation_ordering(Engine, NewSt, Seq + 1, Rest, NewAcc). > + > + > +shuffle(List) -> > + random:seed(os:timestamp()), > > It seems that the random module is deprecated. Could we use the rand > module instead? > > ? > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/couchdb/pull/496#pullrequestreview-46255994>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AABN2RMN9XbSo7OzGBlysSqhKvGuFrnzks5sH63qgaJpZM4NKWJX> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
