janl commented on issue #556: Improve JS test harness restartServer() support fn
URL: https://github.com/apache/couchdb/pull/556#issuecomment-305900596
 
 
   I stand corrected:
   
   ```
   [22:20:29]  <+Wohali>        so restart isn't done that way anymore
   [22:21:33]  <+Wohali>        this took me a bit to figure out
   [22:21:35]  <+Wohali>        
https://github.com/apache/couchdb/blob/master/dev/run#L531-L540
   [22:21:49]  <+Wohali>        so the javascript test suite is invoked as the 
run_command argument to dev/run
   [22:22:07]  <+Wohali>        anything the test suite prints out to stdout is 
parsed by L538
   [22:23:02]  <+Wohali>        so that's how this works: 
https://github.com/apache/couchdb/pull/556/files#diff-10d21021a1d1424fbe10267262a4d4a7L75
   [22:23:19]  <+Wohali>        JS's restartServer() prints restart, which is 
eval()'d by dev/run and restarts the nodes
   [22:23:48]  <+Wohali>        that's why I completely removed the old 
/_restart endpoint call - not only was it eclipsed by the version in 
test_setup.js, it simply doesn't work with 2.0
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to