eiri commented on a change in pull request #560: Fix broken eunit test in
changes_since_test_ test suite
URL: https://github.com/apache/couchdb/pull/560#discussion_r120654676
##########
File path: src/couch_mrview/src/couch_mrview_util.erl
##########
@@ -813,9 +816,13 @@ changes_expand_dups([{{[Key, Seq], DocId}, {dups, Vals}}
| Rest], Acc) ->
changes_expand_dups([{{Seq, Key}, {DocId, {dups, Vals}}} | Rest], Acc) ->
Expanded = [{{Seq, Key, DocId}, Val} || Val <- Vals],
changes_expand_dups(Rest, Expanded ++ Acc);
+changes_expand_dups([{{[Key, Seq], DocId}, {Val, _}} | Rest], Acc) ->
+ changes_expand_dups(Rest, [{{Seq, Key, DocId}, Val} | Acc]);
changes_expand_dups([{{[Key, Seq], DocId}, Val} | Rest], Acc) ->
Review comment:
Remove two added lines and change this one to `changes_expand_dups([{{[Key,
Seq], DocId}, {Val, _}} | Rest], Acc) ->`.
We are defining kseq's value
[here](https://github.com/apache/couchdb/blob/master/src/couch_mrview/src/couch_mrview_util.erl#L903),
the change was done [three years
ago](https://github.com/apache/couchdb/commit/b3fef4cbfcd02178248cedcef5057604ba2d7130)
and on feature not used in Couch 2.0, so there are no need to consider
in-transit change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
