eiri commented on a change in pull request #560: Fix broken eunit test in
changes_since_test_ test suite
URL: https://github.com/apache/couchdb/pull/560#discussion_r120650319
##########
File path: src/couch_mrview/src/couch_mrview.erl
##########
@@ -708,5 +708,5 @@ make_view_changes_opts(StartSeq, Options, Args) ->
true ->
couch_mrview_util:changes_key_opts(StartSeq, Args);
false ->
- [[{start_key, {StartSeq+1, <<>>}}] ++ Options]
+ [[{start_key, {StartSeq, <<>>}}] ++ Options]
Review comment:
On a separate note.
The end-point you looked at `/sdb1/_design/bar/_view/baz` has nothing to do
with code affected by this PR, view operate on `id_btree`, not `seq_btree` or
`kseq_btree`.
This code _supposed_ to be invoked on [end-point
`_view_changes`](https://github.com/apache/couchdb/blob/master/src/couch_mrview/src/couch_mrview_http.erl#L84)
as in `/sdb1/_design/bar/_view_changes`, but it is not on clustered interface,
i.e. it is only accessible from port 15986.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
