davisp commented on a change in pull request #606: Use Ejson Body Instead of
Compressed Body for External size
URL: https://github.com/apache/couchdb/pull/606#discussion_r127019575
##########
File path: src/couch/src/couch_db_updater.erl
##########
@@ -1086,8 +1087,14 @@ copy_docs(Db, #db{fd = DestFd} = NewDb, MixedInfos,
Retry) ->
{NewRevTree, FinalAcc} = couch_key_tree:mapfold(fun
(_Rev, #leaf{ptr=Sp}=Leaf, leaf, SizesAcc) ->
{Body, AttInfos} = copy_doc_attachments(Db, Sp, DestFd),
+ EJsonBody = case is_binary(Body) of
Review comment:
I see why we need to do this for existing shards that may have an incorrect
value however I'm not a huge fan of this being a permanent change and not just
around for an upgrade. Would be nice if we could figure out how to special case
this so it only runs the decompression when we need to upgrade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
