davisp commented on a change in pull request #606: Use Ejson Body Instead of
Compressed Body for External size
URL: https://github.com/apache/couchdb/pull/606#discussion_r127018026
##########
File path: src/couch/src/couch_db.erl
##########
@@ -1111,7 +1111,10 @@ prepare_doc_summaries(Db, BucketList) ->
nil
end,
SummaryChunk = couch_db_updater:make_doc_summary(Db, {Body,
DiskAtts}),
- Doc#doc{body = {summary, SummaryChunk, SizeInfo, AttsFd}}
+ Meta = Doc#doc.meta,
+ ExternalSize = ?term_size(Body),
+ Doc#doc{body = {summary, SummaryChunk, SizeInfo, AttsFd},
Review comment:
Move attributes to their own lines when you wrap records. Something like:
```erlang
Doc#doc{
body = {summary, ...},
meta = [{ejson_size, ?term_size(Body)} | Meta]
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
