nickva commented on a change in pull request #785: Implement attachment size
limits
URL: https://github.com/apache/couchdb/pull/785#discussion_r136611974
##########
File path: src/couch/src/couch_att.erl
##########
@@ -510,19 +517,23 @@ flush_data(Fd, Fun, Att) when is_function(Fun) ->
% WriterFun({0, _Footers}, State)
% Called with Length == 0 on the last time.
% WriterFun returns NewState.
- fun({0, Footers}, _) ->
+ fun({0, Footers}, _Total) ->
Review comment:
Apparently it's a free optimization in recent code.
http://erlang.org/documentation/doc-5.8/doc/efficiency_guide/myths.html (see
the last one)
And it was confusing to read that code before so added it for clarity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
