nickva commented on a change in pull request #785: Implement attachment size
limits
URL: https://github.com/apache/couchdb/pull/785#discussion_r136618993
##########
File path: src/couch/src/couch_att.erl
##########
@@ -510,19 +517,23 @@ flush_data(Fd, Fun, Att) when is_function(Fun) ->
% WriterFun({0, _Footers}, State)
% Called with Length == 0 on the last time.
% WriterFun returns NewState.
- fun({0, Footers}, _) ->
+ fun({0, Footers}, _Total) ->
Review comment:
In this case the meaning of `State` was changed from being a "don't care"
'ok' to something else that's actually used. That's the reason I updated.
In the description above the writer function general call format is
described, in this case we show what the state is used for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
