davisp commented on a change in pull request #806: FEEDBACK ONLY: Compactor optimize emsort URL: https://github.com/apache/couchdb/pull/806#discussion_r139164318
########## File path: src/couch/src/couch_db_updater.erl ########## @@ -1179,12 +1226,13 @@ copy_compact(Db, NewDb0, Retry) -> TaskProps0 = [ {type, database_compaction}, + {retry, (Retry /= nil)}, {database, Db#db.name}, {progress, 0}, {changes_done, 0}, {total_changes, TotalChanges} ], - case (Retry =/= nil) and couch_task_status:is_task_added() of + case (Retry /= nil) and couch_task_status:is_task_added() of Review comment: Nah. I had done some further refactoring trying a different set of optimizations that didn't pan out and this is just my mistake not reverting it correctly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services