davisp commented on a change in pull request #806: FEEDBACK ONLY: Compactor optimize emsort URL: https://github.com/apache/couchdb/pull/806#discussion_r139164899
########## File path: src/couch/src/couch_file.erl ########## @@ -119,6 +121,7 @@ append_term_md5(Fd, Term, Options) -> Comp = couch_util:get_value(compression, Options, ?DEFAULT_COMPRESSION), append_binary_md5(Fd, couch_compress:compress(Term, Comp)). + Review comment: I didn't do a good job cleaning up this PR since I don't expect it to be merged as is (because PSE). I had things in slightly different places as you said before moving them. The organization of couch_file's API isn't very clean so I had a few different spots for it before settling on where it is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services