davisp commented on a change in pull request #818: Rename selector to
partialfilterselector in indexes
URL: https://github.com/apache/couchdb/pull/818#discussion_r140011035
##########
File path: src/mango/src/mango_idx_view.erl
##########
@@ -199,8 +199,8 @@ opts() ->
{tag, fields},
{validator, fun mango_opts:validate_sort/1}
]},
- {<<"selector">>, [
- {tag, selector},
Review comment:
I see the get_legacy_selector code above, but reading through code I can't
convince myself that removing this option definition won't break old indexes
that used the selector name. I wonder if we shouldn't continue to support this
for awhile and upgrade it internally for new indexes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
