davisp commented on a change in pull request #818: Rename selector to
partialfilterselector in indexes
URL: https://github.com/apache/couchdb/pull/818#discussion_r140011473
##########
File path: src/mango/src/mango_idx_view.erl
##########
@@ -199,8 +199,8 @@ opts() ->
{tag, fields},
{validator, fun mango_opts:validate_sort/1}
]},
- {<<"selector">>, [
- {tag, selector},
Review comment:
And/or perhaps just adding a test specifically for the upgrade would be
enough here. And for that I'd like to see us write an old style ddoc directly
and then read the index to make sure it behaves as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
