wohali commented on issue #1160: Add support for Bcrypt password hashing
URL: https://github.com/apache/couchdb/pull/1160#issuecomment-365297966
 
 
   Hi @pierrekilly ,
   
   Oops, I wasn't clear in my comments, sorry about that.
   
   You *should* use the same value for iterations for `bcrypt` and `pbkdf2`. 
   
   You should *not* change the default in the same commit. I see the advice 
that recommends not using less than 10 for the iterations value online, so I 
understand your going with 12, but since this will affect both algorithms, we 
need to be sure this will not cause undue concern for users of `pbkdf2` which 
should remain the default.
   
   If you change the default value you **must** update 
`rel/overlay/etc/default.ini` with the new default value as well. This file 
must always match the default values as specified in the code.
   
   Someone else more focused on this section of the code will have to help this 
PR along further, I'm afraid. That may take some time. If it stalls out too 
long, you should subscribe to `d...@couchdb.apache.org` and send an email 
asking for someone to look over your contribution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to