wohali commented on issue #1160: Add support for Bcrypt password hashing URL: https://github.com/apache/couchdb/pull/1160#issuecomment-369009872 Great work here. I'm unable to comment on the code quality, but if @janl and @rnewson are happy, you've pleased the right people. As someone else has probably mentioned, this needs to be squashed before landing. Sorry to bring this up again... @janl and I discussed the whole `iterations` vs. `log_rounds` being the same or separate. I guess if both encryption types can be supported at once, it can make sense for them to be separate. But if only one type of encryption is supported at the time of creation of a new user, then the parameters would be best to be unified into the single `iterations` existing config value - the [POLA](https://en.wikipedia.org/wiki/Principle_of_least_astonishment) comes into effect. Jan said he'll think about this and drop by in a day or two to comment.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
