nickva commented on a change in pull request #1176: Implement pluggable 
authentication and session support for replicator

 File path: src/couch_replicator/src/couch_replicator_auth_basic.erl
 @@ -0,0 +1,52 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
+% use this file except in compliance with the License. You may obtain a copy of
+% the License at
+% Unless required by applicable law or agreed to in writing, software
+% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+% License for the specific language governing permissions and limitations under
+% the License.
 Review comment:
   The idea is it preserves the current behavior better. For example, if 
credentials are put in the URL directly (`http://user:pass@host/db`) that's how 
they'd be passed to endpoints, as opposed to extracting them and applying them 
as basic auth headers. Most servers should handle basic auth headers but just 
in case there are some hand rolled ones that only know of one way to 
   Another incentive is to use this as a feature flag -- if this is the only 
plugin in the list, it effectively means "do the old behavior before the 
session auth commit".
   Is it worth doing it this way or would it be better to do the full extract 
and reapply?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to