nickva commented on a change in pull request #1176: Implement pluggable authentication and session support for replicator URL: https://github.com/apache/couchdb/pull/1176#discussion_r170301632
########## File path: src/couch_replicator/src/couch_replicator_auth_basic.erl ########## @@ -0,0 +1,52 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file except in compliance with the License. You may obtain a copy of +% the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +% License for the specific language governing permissions and limitations under +% the License. + +-module(couch_replicator_auth_basic). Review comment: Oh doh. That's embarrassing. You're right of course. Don't know what I was thinking. The connection is made to the host:port and then path part is sent sent without all the auth bits in front of it. I guess the only difference then is letting ibrowse do the appending of basic auth header or not. As for the module should it be better called couch_replicator_auth_default - basically a catch-all module that is no-op and just mean "do whatever happened before". The reason for a separate module is that in some case users might enforce not falling back basic auth. Then they wouldn't add it to the end of the plugins list. Or do you think it's still better to do the extract basic auth, and then reply dance and keep its name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
