janl commented on a change in pull request #1253: [DISCUSS] Validate new
document writes against max_http_request_size
URL: https://github.com/apache/couchdb/pull/1253#discussion_r178029434
##########
File path: src/couch/src/couch_att.erl
##########
@@ -708,6 +709,9 @@ upgrade(#att{} = Att) ->
upgrade(Att) ->
Att.
+to_tuple(#att{name=Name, att_len=Len, type=Type, encoding=Encoding}) ->
Review comment:
The only reason this exists is because
`couch_multipart_httpd:length_multipart_stream()` [makes
assumptions](https://github.com/apache/couchdb/blob/master/src/couch/src/couch_httpd_multipart.erl#L266)
about the format of the stub. This is usually called from `chttpd`. I didn’t
find a way around this without exposing `couch_att`’s `att#` record.
But yeah, I’m very okay with any other name here. What would be better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
