janl commented on a change in pull request #1253: [DISCUSS] Validate new document writes against max_http_request_size URL: https://github.com/apache/couchdb/pull/1253#discussion_r202397028
########## File path: src/couch/src/couch_att.erl ########## @@ -708,6 +709,9 @@ upgrade(#att{} = Att) -> upgrade(Att) -> Att. +to_tuple(#att{name=Name, att_len=Len, type=Type, encoding=Encoding}) -> Review comment: ``` [16:26:10] <+jan____> rnewson: do you have a better name for to_tuple in https://github.com/apache/couchdb/pull/1253/files#r178029434? [16:27:14] <+rnewson> I don't, proceed with to_tuple. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services