garrensmith commented on a change in pull request #102: Promise support for 
Nano - Issue 98
URL: https://github.com/apache/couchdb-nano/pull/102#discussion_r203304651
 
 

 ##########
 File path: lib/nano.js
 ##########
 @@ -68,6 +67,89 @@ module.exports = exports = nano = function dbScope(cfg) {
     }
     return str;
   }
+  var responseHandler = function(req, opts, resolve, reject, callback) {
+    
+    return function(e, h, b) {
 
 Review comment:
   You do a fiew checks lower to check if h exists. You can do something like 
this instead:
   
   ```
   return function (e, h = {}, b) {
   ```
   
   That way `h` will default to an empty header. Also could you rename it to 
header because I think that is what it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to