garrensmith commented on a change in pull request #102: Promise support for
Nano - Issue 98
URL: https://github.com/apache/couchdb-nano/pull/102#discussion_r203304131
##########
File path: lib/nano.js
##########
@@ -68,6 +67,89 @@ module.exports = exports = nano = function dbScope(cfg) {
}
return str;
}
+ var responseHandler = function(req, opts, resolve, reject, callback) {
+
+ return function(e, h, b) {
+ var parsed;
+ var rh = h && h.headers || {};
Review comment:
I think this can be simplified to:
```
const responseHeader = Object.assign({
uri: req.uri,
statusCode: h.statusCode
}, h.headers);
```
I'm not a huge fan of such short variable names. Its difficult to figure out
what it is. I would before something that explains what this is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
