iilyak commented on a change in pull request #1581: Fix dialyzer warning of
shard record construction
URL: https://github.com/apache/couchdb/pull/1581#discussion_r212979225
##########
File path: src/mem3/include/mem3.hrl
##########
@@ -12,12 +12,12 @@
% type specification hacked to suppress dialyzer warning re: match spec
-record(shard, {
- name :: binary() | '_',
- node :: node() | '_',
- dbname :: binary(),
- range :: [non_neg_integer() | '$1' | '$2'] | '_',
+ name :: binary() | '_' | 'undefined',
Review comment:
For `ref` the order is `'undefined' | '_'`, for others is `'_' |
'undefined'`. Other than that looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
