iilyak commented on a change in pull request #1605: Feature/user partitioned
databases
URL: https://github.com/apache/couchdb/pull/1605#discussion_r224049186
##########
File path: src/couch/src/couch_btree.erl
##########
@@ -133,7 +133,9 @@ make_group_fun(Bt, exact) ->
end;
make_group_fun(Bt, GroupLevel) when is_integer(GroupLevel), GroupLevel > 0 ->
fun
- ({[_|_] = Key1, _}, {[_|_] = Key2, _}) ->
+ GF({{p, _Partition, Key1}, Val1}, {{p, _Partition, Key2}, Val2}) ->
Review comment:
Is there any possibility that we would we have a case were Partition value
is different? I think we would have such cases. That would mean that there
would be no match and we crash.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services