iilyak commented on a change in pull request #1605: Feature/user partitioned
databases
URL: https://github.com/apache/couchdb/pull/1605#discussion_r224052343
##########
File path: src/couch/src/couch_db_updater.erl
##########
@@ -88,6 +88,14 @@ handle_call({set_security, NewSec}, _From, #db{} = Db) ->
ok = gen_server:call(couch_server, {db_updated, NewSecDb}, infinity),
{reply, ok, NewSecDb, idle_limit()};
+handle_call({set_prop, Key, Value}, _From, #db{} = Db) ->
Review comment:
I am not sure if we should detect a case when we set the same property
multiple times. I.e. the case when the result from
`couch_db_engine:get_props/1` is the same before and after calling `set_prop`.
In such case we might want to avoid doing a commit and sending `db_updated`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
