wohali commented on a change in pull request #36: Modifications for openSUSE support URL: https://github.com/apache/couchdb-pkg/pull/36#discussion_r231577236
########## File path: rpm/SPECS/couchdb.spec ########## @@ -33,29 +33,49 @@ ExclusiveArch: x86_64 Exclusiveos: linux Packager: CouchDB Developers <d...@couchdb.apache.org> +%if 0%{?suse_version} +BuildRequires: erlang +BuildRequires: erlang-rebar +BuildRequires: erlang-reltool +BuildRequires: erlang-epmd +BuildRequires: gcc-c++ +BuildRequires: pkg-config +Requires(pre): shadow +BuildRequires: python3 +Requires(post): python3-progressbar +Requires(post): python3-requests +%else BuildRequires: esl-erlang BuildRequires: gcc +Requires(pre): shadow-utils +BuildRequires: python >= 2.6 +#BuildRequires: python-pip +#BuildRequires: python-sphinx >= 1.5.3 +Requires(post): python-progressbar +Requires(post): python-requests +%endif + BuildRequires: git BuildRequires: help2man #BuildRequires: couch-js-devel = 1:1.8.5 BuildRequires: libcurl-devel BuildRequires: libicu-devel BuildRequires: nodejs >= 6.10.1 -BuildRequires: python >= 2.6 -#BuildRequires: python-pip -#BuildRequires: python-sphinx >= 1.5.3 - -Requires(pre): shadow-utils Requires(post): curl Requires(post): couch-js = 1:1.8.5 Requires(post): libicu >= 4.2.1 Requires(post): procps -Requires(post): python-progressbar -Requires(post): python-requests +%if 0%{?suse_version} +Requires(post): erlang Review comment: This `%if` block needs to be removed. Once CouchDB is installed by package, no separate Erlang runtime is required. Can you confirm please? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services