wohali commented on a change in pull request #36: Modifications for openSUSE support URL: https://github.com/apache/couchdb-pkg/pull/36#discussion_r231577865
########## File path: rpm/SPECS/couchdb.spec ########## @@ -33,29 +33,49 @@ ExclusiveArch: x86_64 Exclusiveos: linux Packager: CouchDB Developers <d...@couchdb.apache.org> +%if 0%{?suse_version} +BuildRequires: erlang +BuildRequires: erlang-rebar +BuildRequires: erlang-reltool +BuildRequires: erlang-epmd +BuildRequires: gcc-c++ +BuildRequires: pkg-config +Requires(pre): shadow +BuildRequires: python3 Review comment: This is not correct. Many of the python scripts in 2.2.0 are not yet python 3 compatible. This will be remedied with https://github.com/apache/couchdb/pull/1639 and should arrive in 2.3.0. I can either wait to merge this until 2.3.0 is released, or you can change this (and the following lines) to python2 and wait to file another PR when 2.3.0 comes out. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services