dottorblaster commented on issue #1769: Add Credo to Elixir test suite
URL: https://github.com/apache/couchdb/pull/1769#issuecomment-442427693
 
 
   Here is a rationale of this PR.
   
   I added Credo to the Mix project, then I disabled some "not so useful" 
checks. They are:
   
   - `Credo.Check.Refactor.CyclomaticComplexity`
   - `Credo.Check.Refactor.LongQuoteBlocks`
   - `Credo.Check.Refactor.Nesting`
   
   Then, I added Credo to the Makefile and Makefile.win with a proper goal, and 
I added that goal to `make elixir`. This way, `make elixir` formats the code 
according to #1767, then executes the `elixir-credo` goal erroring on basically 
everything.
   
   The only check I maintained but I changed its exit code to `0` is 
`Credo.Check.Design.TagTODO`, because I want to be warned about TODOs and 
monitor them, but I still want to be able to use them as reminders.
   
   @wohali I think your eyes could be useful here 🙂 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to