dottorblaster commented on issue #1769: Add Credo to Elixir test suite URL: https://github.com/apache/couchdb/pull/1769#issuecomment-442767475 Some comments on the above discussion: - Wow, you were great guys, that was such a beautiful debate 😬 - I enforced max line length to `120` because our formatter enforces the coding style to 120-chars lines. I'm gonna take it to `90` in Credo, and of course I'm updating the `.formatter.exs` as well. - Also, I love the 120 limit, and the community does. But if we want to enforce a 90 columns limit, that's the beautiful point of having a tool that you can configure 😹 - About disabling `Credo.Check.Consistency.ParameterPatternMatching` and the long quotes one: `Consistency.ParameterPatternMatching` is ok, but I think: 1) that we need a long quote block for our test helper 2) that long quote blocks are smells and we should limit that smell to a known place. Enforcing a 90 columns format will cause almost all of our tests to be reformatted. @wohali et al. do you want me to go further or do we want to do that in another subsequent PR?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
