iilyak commented on a change in pull request #1789: New Feature: Database
Partitions
URL: https://github.com/apache/couchdb/pull/1789#discussion_r239194004
##########
File path: src/couch/src/couch_db.erl
##########
@@ -583,6 +603,10 @@ get_db_info(Db) ->
undefined -> null;
Else1 -> Else1
end,
+ Props = case couch_db_engine:get_props(Db) of
+ undefined -> null;
Review comment:
I'm lost a bit here (why not `[]`?). IRC we pass the `InfoList` to
`jiffy:encode/1`. `jiffy` crashes as follows:
```
jiffy:encode({[{props, {null}}]}).
** exception throw: {error,{invalid_object,{null}}}
in function jiffy:encode/2 (src/jiffy.erl, line 97)
```
Type mutation is going to be a problem for client libraries written in
statically compiled languages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
