iilyak commented on a change in pull request #1789: New Feature: Database
Partitions
URL: https://github.com/apache/couchdb/pull/1789#discussion_r239790614
##########
File path: src/couch/src/couch_db.erl
##########
@@ -184,11 +189,22 @@ reopen(#db{} = Db) ->
incref(#db{} = Db) ->
couch_db_engine:incref(Db).
-clustered_db(DbName, UserCtx) ->
- clustered_db(DbName, UserCtx, []).
+clustered_db(DbName, Options) when is_list(Options) ->
+ UserCtx = couch_util:get_value(user_ctx, Options),
Review comment:
Are there cases when user_ctx is not in Options. Should we change it to
`couch_util:get_value(user_ctx, Options, #user_ctx{}),`? Since default value
for user_ctx should be `#user_ctx{}` (see here
https://github.com/apache/couchdb/blob/master/src/couch/src/couch_db_int.hrl#L28).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
