kocolosk commented on a change in pull request #165: dev: debian-buster, node 10, SM60 URL: https://github.com/apache/couchdb-docker/pull/165#discussion_r375025684
########## File path: dev/Dockerfile ########## @@ -129,7 +129,7 @@ RUN ./configure FROM build_dependencies AS build ARG checkout_branch=master -ARG configure_options +ARG configure_options="-c --spidermonkey-version 60" Review comment: This is a little surprising because it gets dropped if a user specifies `configure_options` on the command line. I got bitten by it when my usual `--build-arg configure_options="--disable-docs"` invocation stopped working after this change. Also, why specify `-c` here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
