wohali commented on a change in pull request #165: dev: debian-buster, node 10, SM60 URL: https://github.com/apache/couchdb-docker/pull/165#discussion_r375064130
########## File path: dev/Dockerfile ########## @@ -129,7 +129,7 @@ RUN ./configure FROM build_dependencies AS build ARG checkout_branch=master -ARG configure_options +ARG configure_options="-c --spidermonkey-version 60" Review comment: @kocolosk Yeah, I'm not sure how to handle this more elegantly; feel free to propose a solution. The default choice of `1.8.5` doesn't work in the image now that we're selectively only installing libmozjs-60, which was a conscious decision so I can gradually deprecate the 1.8.5 packages. But we can't make the new default 60 yet, since it will fail on just about every other OS at the moment. Without `-c` you can't use the libcurl bindings in javascript, which developers arguably might want to do. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
