iilyak commented on a change in pull request #3568:
URL: https://github.com/apache/couchdb/pull/3568#discussion_r633801347
##########
File path: src/chttpd/src/chttpd_db.erl
##########
@@ -805,474 +898,572 @@ paginate_all_docs_view(Req, Db, Args0, OP) ->
UpdateSeq = fabric2_db:get_update_seq(Db),
EtagTerm = {Parts, UpdateSeq, Args3},
Response = couch_views_http:paginated(
- Req, EtagTerm, Args3, KeyFun,
+ Req,
+ EtagTerm,
+ Args3,
+ KeyFun,
fun(Args) ->
all_docs_paginated_cb(Db, Args)
- end),
+ end
+ ),
chttpd:send_json(Req, Response).
-
all_docs_paginated_cb(Db, Args) ->
- #vacc{meta=MetaMap, buffer=Items} = case Args#mrargs.keys of
- undefined ->
- send_all_docs(Db, Args, #vacc{paginated=true});
- Keys when is_list(Keys) ->
- send_all_docs_keys(Db, Args, #vacc{paginated=true})
- end,
+ #vacc{meta = MetaMap, buffer = Items} =
+ case Args#mrargs.keys of
+ undefined ->
+ send_all_docs(Db, Args, #vacc{paginated = true});
+ Keys when is_list(Keys) ->
+ send_all_docs_keys(Db, Args, #vacc{paginated = true})
+ end,
{MetaMap, Items}.
-
send_all_docs(Db, #mrargs{keys = undefined} = Args, VAcc0) ->
Opts0 = fabric2_util:all_docs_view_opts(Args),
NS = couch_util:get_value(namespace, Opts0),
- FoldFun = case NS of
- <<"_all_docs">> -> fold_docs;
- <<"_design">> -> fold_design_docs;
- <<"_local">> -> fold_local_docs
- end,
- Opts = case couch_views_util:is_paginated(Args) of
- false ->
- Opts0 ++ [{restart_tx, true}];
- true ->
- Opts0
- end,
+ FoldFun =
+ case NS of
+ <<"_all_docs">> -> fold_docs;
+ <<"_design">> -> fold_design_docs;
+ <<"_local">> -> fold_local_docs
+ end,
+ Opts =
+ case couch_views_util:is_paginated(Args) of
+ false ->
+ Opts0 ++ [{restart_tx, true}];
+ true ->
+ Opts0
+ end,
ViewCb = fun view_cb/2,
Acc = {iter, Db, Args, VAcc0},
{ok, {iter, _, _, VAcc1}} = fabric2_db:FoldFun(Db, ViewCb, Acc, Opts),
VAcc1.
-
send_all_docs_keys(Db, #mrargs{} = Args, VAcc0) ->
Keys = apply_args_to_keylist(Args, Args#mrargs.keys),
NS = couch_util:get_value(namespace, Args#mrargs.extra),
TotalRows = fabric2_db:get_doc_count(Db, NS),
- Meta = case Args#mrargs.update_seq of
- true ->
- UpdateSeq = fabric2_db:get_update_seq(Db),
- [{update_seq, UpdateSeq}];
- false ->
- []
- end ++ [{total, TotalRows}, {offset, null}],
+ Meta =
+ case Args#mrargs.update_seq of
+ true ->
+ UpdateSeq = fabric2_db:get_update_seq(Db),
+ [{update_seq, UpdateSeq}];
+ false ->
+ []
+ end ++ [{total, TotalRows}, {offset, null}],
{ok, VAcc1} = view_cb({meta, Meta}, VAcc0),
- DocOpts = case Args#mrargs.conflicts of
- true -> [conflicts | Args#mrargs.doc_options];
- _ -> Args#mrargs.doc_options
- end,
+ DocOpts =
+ case Args#mrargs.conflicts of
+ true -> [conflicts | Args#mrargs.doc_options];
+ _ -> Args#mrargs.doc_options
+ end,
IncludeDocs = Args#mrargs.include_docs,
OpenOpts = [deleted | DocOpts],
CB = fun(DocId, Doc, Acc) ->
- Row0 = case Doc of
- {not_found, missing} ->
- #view_row{key = DocId};
- {ok, #doc{deleted = true, revs = Revs}} ->
- {RevPos, [RevId | _]} = Revs,
- Value = {[
- {rev, couch_doc:rev_to_str({RevPos, RevId})},
- {deleted, true}
- ]},
- DocValue = if not IncludeDocs -> undefined; true ->
- null
- end,
- #view_row{
- key = DocId,
- id = DocId,
- value = Value,
- doc = DocValue
- };
- {ok, #doc{revs = Revs} = Doc0} ->
- {RevPos, [RevId | _]} = Revs,
- Value = {[
- {rev, couch_doc:rev_to_str({RevPos, RevId})}
- ]},
- DocValue = if not IncludeDocs -> undefined; true ->
- couch_doc:to_json_obj(Doc0, DocOpts)
- end,
- #view_row{
- key = DocId,
- id = DocId,
- value = Value,
- doc = DocValue
- }
- end,
+ Row0 =
+ case Doc of
+ {not_found, missing} ->
+ #view_row{key = DocId};
+ {ok, #doc{deleted = true, revs = Revs}} ->
+ {RevPos, [RevId | _]} = Revs,
+ Value =
+ {[
+ {rev, couch_doc:rev_to_str({RevPos, RevId})},
+ {deleted, true}
+ ]},
+ DocValue =
+ if
+ not IncludeDocs -> undefined;
Review comment:
0. Looks strange but make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
