nickva commented on a change in pull request #3568:
URL: https://github.com/apache/couchdb/pull/3568#discussion_r633806581
##########
File path: src/chttpd/src/chttpd.erl
##########
@@ -537,15 +641,22 @@ extract_cookie(#httpd{mochi_req = MochiReq}) ->
%%% end hack
set_auth_handlers() ->
- AuthenticationDefault = "{chttpd_auth, cookie_authentication_handler},
- {chttpd_auth, default_authentication_handler}",
+ AuthenticationDefault =
+ "{chttpd_auth, cookie_authentication_handler},\n"
+ " {chttpd_auth, default_authentication_handler}",
AuthenticationSrcs = couch_httpd:make_fun_spec_strs(
- config:get("chttpd", "authentication_handlers",
AuthenticationDefault)),
+ config:get("chttpd", "authentication_handlers", AuthenticationDefault)
+ ),
AuthHandlers = lists:map(
- fun(A) -> {auth_handler_name(A), couch_httpd:make_arity_1_fun(A)} end,
AuthenticationSrcs),
- AuthenticationFuns = AuthHandlers ++ [
- fun chttpd_auth:party_mode_handler/1 %% must be last
- ],
+ fun(A) -> {auth_handler_name(A), couch_httpd:make_arity_1_fun(A)} end,
Review comment:
+1
##########
File path: src/chttpd/src/chttpd.erl
##########
@@ -993,8 +1112,10 @@ error_info({conflict, _}) ->
{409, <<"conflict">>, <<"Document update conflict.">>};
error_info({partition_overflow, DocId}) ->
Descr = <<
- "Partition limit exceeded due to update on '", DocId/binary, "'"
- >>,
+ "Partition limit exceeded due to update on '",
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
