nickva commented on a change in pull request #5:
URL: https://github.com/apache/couchdb-mochiweb/pull/5#discussion_r639087259
##########
File path: src/mochiweb_socket.erl
##########
@@ -30,7 +30,7 @@ listen(Ssl, Port, Opts, SslOpts) ->
end.
add_unbroken_ciphers_default(Opts) ->
- Default = filter_unsecure_cipher_suites(ssl:cipher_suites()),
+ Default = filter_unsecure_cipher_suites(ssl:cipher_suites(default,
'tlsv1.3')),
Review comment:
Also don't forget to add some documentation or references about the API
differences. That is, what exactly changed and why the line is needed. I took a
quick look at https://erlang.org/doc/man/ssl.html#cipher_suites-2 but couldn't
immediately tell.
To make comparisons easier with older versions, there is
https://erldocs.com/. There you can pick an older version of docs and it would
be more obvious what has changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
