nickva commented on a change in pull request #5:
URL: https://github.com/apache/couchdb-mochiweb/pull/5#discussion_r640101898
##########
File path: src/mochiweb_socket.erl
##########
@@ -44,11 +56,14 @@ filter_broken_cipher_suites(Ciphers) ->
Ciphers
end.
+%% Filter old tuple style cipher suites and new map style cipher suites
filter_unsecure_cipher_suites(Ciphers) ->
lists:filter(fun
({_,des_cbc,_}) -> false;
({_,_,md5}) -> false;
- (_) -> true
+ (_) -> true;
+ (#{key_exchange := des_cbc}) -> false;
+ (#{mac := md5}) -> false
Review comment:
These lines should be moved above the (_) "catchall" case. Otherwise the
(_) will match first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
