nickva commented on pull request #5:
URL: https://github.com/apache/couchdb-mochiweb/pull/5#issuecomment-849990624
Saw another failure in 22.0
```
::{function_clause,[{dtls_v1,corresponding_tls_version,
['tlsv1.3'],
[{file,"dtls_v1.erl"},{line,55}]},
{dtls_v1,all_suites,1,[{file,"dtls_v1.erl"},{line,41}]},
{ssl,cipher_suites,2,[{file,"ssl.erl"},{line,987}]},
```
I verified it with my own build of 22.0:
```
17> Vers = proplists:get_value(available, ssl:versions()).
['tlsv1.3','tlsv1.2','tlsv1.1',tlsv1,sslv3]
18> catch ssl:cipher_suites(default, 'tlsv1.3').
{'EXIT',{function_clause,[{ssl_cipher,suites,
['tlsv1.3'],
[{file,"ssl_cipher.erl"},{line,276}]},
{ssl,cipher_suites,2,[{file,"ssl.erl"},{line,987}]},
{erl_eval,do_apply,6,[{file,"erl_eval.erl"},{line,684}]},
{erl_eval,expr,5,[{file,"erl_eval.erl"},{line,437}]},
{shell,exprs,7,[{file,"shell.erl"},{line,686}]},
{shell,eval_exprs,7,[{file,"shell.erl"},{line,642}]},
{shell,eval_loop,3,[{file,"shell.erl"},{line,627}]}]}}
```
And noticed in later versions of 22 like 22.3.4.16 it works...:
```
3> _ = ssl:cipher_suites(default, 'tlsv1.3'), ok.
ok
```
So maybe we'd just end up using the same `new_crypto_unavailable` macro
instead of the `new_ssl_available` as both seem to point to 23 being the cutoff
release which handle new cipher and new crypto properly.
It seems that map-based cipher suites are supported in 20-21, and higher
versions of 22, but in 22.0 the `ssl:cipher_suites(all | default, Version)`
would sometimes fail. To avoid doing fine-grained special cases we might just
make 23 the smallest version and call it a day.
But that means we would like to add 23 to the list of tests and hopefully
soon enough Travis CI would add 24 to some repos too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
