bessbd commented on a change in pull request #3637:
URL: https://github.com/apache/couchdb/pull/3637#discussion_r656719490
##########
File path: test/elixir/test/security_validation_test.exs
##########
@@ -12,19 +12,19 @@ defmodule SecurityValidationTest do
@auth_headers %{
jerry: [
# jerry:mouse
- authorization: "Basic amVycnk6bW91c2U="
+ authorization: "basic amVycnk6bW91c2U="
],
tom: [
# tom:cat
- authorization: "Basic dG9tOmNhdA=="
+ authorization: "BAsIc dG9tOmNhdA=="
],
spike_cat: [
# spike:cat - which is wrong
authorization: "Basic c3Bpa2U6Y2F0"
],
spike: [
# spike:dog
- authorization: "Basic c3Bpa2U6ZG9n"
+ authorization: "BASIC c3Bpa2U6ZG9n"
Review comment:
This seems like a [piggyback](https://stackoverflow.com/a/333883) to me.
Can you please add a test case that would fail without your production code
change, but passes with it? That way when we're changing code parts related to
this fix, we have one specific test case that shows us what exactly is about to
break and it is clearly listed in the test report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
