noahshaw11 commented on a change in pull request #3637:
URL: https://github.com/apache/couchdb/pull/3637#discussion_r657188723
##########
File path: test/elixir/test/security_validation_test.exs
##########
@@ -12,19 +12,19 @@ defmodule SecurityValidationTest do
@auth_headers %{
jerry: [
# jerry:mouse
- authorization: "Basic amVycnk6bW91c2U="
+ authorization: "basic amVycnk6bW91c2U="
],
tom: [
# tom:cat
- authorization: "Basic dG9tOmNhdA=="
+ authorization: "BAsIc dG9tOmNhdA=="
],
spike_cat: [
# spike:cat - which is wrong
authorization: "Basic c3Bpa2U6Y2F0"
],
spike: [
# spike:dog
- authorization: "Basic c3Bpa2U6ZG9n"
+ authorization: "BASIC c3Bpa2U6ZG9n"
Review comment:
Added three new test cases to test lowercase, uppercase, and mixed case
"Basic". See
https://github.com/apache/couchdb/pull/3637/commits/a6c2028adf8f717b3a9ec97835388a456fb1ce03
and
https://github.com/apache/couchdb/pull/3637/commits/33c38d2ae8f5dd77f38d29170217f0ea794d87e9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
