iilyak commented on a change in pull request #3638:
URL: https://github.com/apache/couchdb/pull/3638#discussion_r657838846
##########
File path: src/chttpd/src/chttpd.erl
##########
@@ -677,7 +677,7 @@ absolute_uri(#httpd{absolute_uri = URI}, Path) ->
URI ++ Path.
unquote(UrlEncodedString) ->
- mochiweb_util:unquote(UrlEncodedString).
+ chttpd_util:unquote(UrlEncodedString).
Review comment:
We shouldn't change `chttpd:unquote/1`. Unquote is used everywhere and
should keep converting + into space.
The only exception when it shouldn't is for path component of the URL. I
suggest to create `chttpd:unquote_path/1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
