jaydoane opened a new pull request #3782:
URL: https://github.com/apache/couchdb/pull/3782
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from
committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
- Replace unused variable with underscore
- Add nowarn_export_all compiler option
- Use STACKTRACE macro
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
## Testing recommendations
```
make
```
Should no longer display e.g.
```
src/chttpd/src/chttpd_node.erl:35: Warning: variable 'Node' is unused
src/couch_pse_tests/src/cpse_test_purge_seqs.erl:14: Warning: export_all
flag enabled - all functions will be exported
src/smoosh/src/smoosh_server.erl:251: Warning: erlang:get_stacktrace/0:
deprecated; use the new try/catch syntax for retrieving the stack backtrace
C
```
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here.
-->
## Checklist
- [x] Code is written and works correctly
- [x] Changes are covered by tests
- [ ] Any new configurable parameters are documented in
`rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in
https://github.com/apache/couchdb-documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
