nickva commented on a change in pull request #3782: URL: https://github.com/apache/couchdb/pull/3782#discussion_r726701467
########## File path: src/chttpd/src/chttpd_node.erl ########## @@ -32,7 +32,7 @@ handle_node_req(#httpd{path_parts=[_, <<"_local">>]}=Req) -> handle_node_req(#httpd{path_parts=[A, <<"_local">>|Rest]}=Req) -> handle_node_req(Req#httpd{path_parts=[A, node()] ++ Rest}); % GET /_node/$node/_versions -handle_node_req(#httpd{method='GET', path_parts=[_, Node, <<"_versions">>]}=Req) -> +handle_node_req(#httpd{method='GET', path_parts=[_, _, <<"_versions">>]}=Req) -> Review comment: Below in the next clause we used `_Node` we could stick with the same clause. Alternatively, if it looks better to you, we could make both `_` as it's fairly obvious from the comment in line 34 what the path elements are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org