nickva commented on a change in pull request #3969:
URL: https://github.com/apache/couchdb/pull/3969#discussion_r836803636
##########
File path: src/couch_mrview/include/couch_mrview.hrl
##########
@@ -70,7 +70,9 @@
direction = fwd,
limit = ?MAX_VIEW_LIMIT,
+ max_view = ?MAX_VIEW_LIMIT,
skip = 0,
+ skip_design = false,
Review comment:
We are modifying the `#mrargs` record. I believe this record is passed
between nodes. In that case, say if there is a life service ;-) which upgrades
nodes in a rolling reboot fashion, the mis-matched `#mrargs` fields would cause
view and view-like queries from old to new nodes to crash.
One option here could be to use the `extra` props field. It's not pretty but
it should help for live upgrades. Eventually we should probably just switch to
a map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
