nickva commented on a change in pull request #3969:
URL: https://github.com/apache/couchdb/pull/3969#discussion_r836811229
##########
File path: src/chttpd/src/chttpd_misc.erl
##########
@@ -146,7 +148,7 @@ all_dbs_info_callback({row, Row}, #vacc{resp = Resp0} =
Acc) when
Prepend = couch_mrview_http:prepend_val(Acc),
case couch_util:get_value(id, Row) of
<<"_design", _/binary>> ->
- {ok, Acc};
+ {skip, Acc};
Review comment:
I think it's a bit confusing that we handle the skip in both the
callback (by returning {skip, ...}) and in the caller where we look at
skip_design and manage Skip and Limit in
```
case Key of
<<"_design", _/binary>> -> Skip;
_ -> Skip - 1
end,
```
We should see if we could take a different approach perhaps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
