janl commented on code in PR #4152:
URL: https://github.com/apache/couchdb/pull/4152#discussion_r950668450
##########
src/fabric/src/fabric_view_all_docs.erl:
##########
@@ -286,6 +286,20 @@ all_docs_concurrency() ->
10
end.
+validate_if_partition(Row, Acc) ->
+ QueryStr = Acc#vacc.req#httpd.qs,
+ case QueryStr of
+ undefined -> Row;
+ [{"partition", Id}] -> is_doc_in_partition(Row, Id)
Review Comment:
this only matches if the `qs` is either `undefined` or exactly the list
`[{"partition", Id}]` — is this always the case? Can there be other options in
the qs? If yes, we’d probably need to get the partition tuple out with a
`proplists:get()` or `couch_util:get_value()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
