janl commented on PR #4152:
URL: https://github.com/apache/couchdb/pull/4152#issuecomment-1221259044
Thanks for this, this looks decent overall, especially for a first
contribution :)
I left a few minor notes on the code. I just have one question about the
approach taken here.
The way I read it: passing keys to match into the query will return result
rows we do not want. So this PR starts preventing those result rows from being
returned.
Would another option to solve this be making it so that we don’t read those
rows in the first place? That would make this a performance improvement too.
We might even be able to do this at the request validation stage: if `keys`
includes a partition that is not the partition of the URL being queried, we
return a 400 error with a message that all keys must match the partition
provided in the URL.
Just spitballing here tho. Nice work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
