mikerhodes commented on code in PR #4394:
URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082582977
##########
src/mango/src/mango_cursor_view.erl:
##########
@@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) ->
key = couch_util:get_value(key, Row),
doc = couch_util:get_value(doc, Row)
},
+ % This supports receiving our "arguments" either as just the `selector`
+ % or in the new record in `callback_args`. This is to support mid-upgrade
+ % clusters where the non-upgraded coordinator nodes will send the older
style.
+ % TODO remove this in a couple of couchdb versions.
Review Comment:
This seems reasonable. My question is: does this removal need to wait for
4.x, given it's not a breaking change, or does it need t wait a couple of minor
- or patch - releases?
I don't know how many people do rolling upgrades outside of Cloudant, as
opposed to just stopping the world for a few minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
