nickva commented on code in PR #4394:
URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082853325
##########
src/mango/src/mango_cursor_view.erl:
##########
@@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) ->
key = couch_util:get_value(key, Row),
doc = couch_util:get_value(doc, Row)
},
+ % This supports receiving our "arguments" either as just the `selector`
+ % or in the new record in `callback_args`. This is to support mid-upgrade
+ % clusters where the non-upgraded coordinator nodes will send the older
style.
+ % TODO remove this in a couple of couchdb versions.
Review Comment:
We've been informally tagging those with "backwards compatibility" or
"upgrade clause" notes in the comments. Searching for "TODO" would work as
well. Some official marker would be better, of course.
Another way is to add a config parameter like we had for rexi use_kill_all
but there is a balance there.
But I am inclined to merge it as is and do the extra formalizing as another
task
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
