rnewson opened a new pull request, #4729: URL: https://github.com/apache/couchdb/pull/4729
## Overview Fabric workers should exit if the client exits. I enhanced the dev haproxy.cfg so that we can see haproxy log output too (I also capture the x-couch-request-id so we can match it to couch.log output) Note: I make another copy of all the jobs in order to index them by the new client monitor reference. The job record is small, two pids and three references, so I'm not hugely concerned. However we could eliminate it and do a table scan in the fallback case in DOWN if the Ref is not a worker itself. ## Testing recommendations * start dev/run with log level debug * make a new empty database * tail couch.log of all nodes in other terminals * in a terminal run `curl -i 'localhost:5984/dbname/_changes?feed=continuous&since=now&timeout=100000000000000000000'` * CTRL-C in the curl terminal * notice the debug log for two fabric workers that exit (q=2 by default) I intend to add automated tests for this but wanted to get the diff in front of the team first. ## Related Issues or Pull Requests N/A ## Checklist - [x] Code is written and works correctly - [ ] Changes are covered by tests - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini` - [ ] Documentation changes were made in the `src/docs` folder - [ ] Documentation changes were backported (separated PR) to affected branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
