nickva commented on code in PR #4729:
URL: https://github.com/apache/couchdb/pull/4729#discussion_r1298913972


##########
rel/haproxy.cfg:
##########
@@ -25,9 +25,9 @@ defaults
         option redispatch
         retries 4
         option http-server-close
-        timeout client 150000
-        timeout server 3600000
-        timeout connect 500
+        timeout client 60s
+        timeout server 60s

Review Comment:
   At least for changes it's not needed as we already have a changes timeout 
max default of 60 seconds. That behavior is a bit odd, no matter what the user 
passes in as the timeout we always pick the minimum of the default and user's 
timeout: 
https://github.com/apache/couchdb/blob/e60e27554708f46a9e6528fa6049d025c1aba859/src/couch/src/couch_changes.erl#L401
 I guess it's for cases of multi-tenant clusters to limit the timeout upper 
limit?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to